julianhyde commented on PR #3234: URL: https://github.com/apache/calcite/pull/3234#issuecomment-1603396506
Two options. You can choose. Whichever you choose needs to be documented in the Jira. If SAFE_MULTIPLY applied to two TINYINT values returns a BIGINT there's no point having a SAFE_MULTIPLY(TINYINT, TINYINT) function. You might as well call SAFE_MULTIPLY(BIGINT, BIGINT) and use implicit arg conversion. If you want to have `SAFE_MULTIPLY(TINYINT, TINYINT)` return `TINYINT` (and similar variations for other integer types) that's fine too. Just make sure that you throw iff the result doesn't fit in a `TINYINT`. You could probably implement it by multiplying in the `int` domain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
