JingDas commented on code in PR #3264:
URL: https://github.com/apache/calcite/pull/3264#discussion_r1239146276
##########
core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinRemoveRule.java:
##########
@@ -128,21 +141,20 @@ public ProjectJoinRemoveRule(
BooleanSupplier isLeftSideReserved = () -> isLeftJoin || (isInnerJoin &&
onlyUseLeft);
final List<Integer> joinKeys = isLeftSideReserved.getAsBoolean() ?
rightKeys : leftKeys;
- if (!Boolean.TRUE.equals(
+ if (Boolean.FALSE.equals(
mq.areColumnsUnique(isLeftSideReserved.getAsBoolean() ?
join.getRight() : join.getLeft(),
ImmutableBitSet.of(joinKeys)))) {
return;
}
RelNode node;
if (isLeftSideReserved.getAsBoolean()) {
- node = project
- .copy(project.getTraitSet(), join.getLeft(), project.getProjects(),
- project.getRowType());
+ node =
+ project.copy(project.getTraitSet(), join.getLeft(),
+ project.getProjects(), project.getRowType());
Review Comment:
I think you are right, I also agree with you.
This newline operation is edited by check style.
I'll give it a try as we agreed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
