jhugomoore opened a new pull request, #3281: URL: https://github.com/apache/calcite/pull/3281
Exploring what would have to change in ReltoSqlConverterTest in order to simplify SqlImplementor->Context->orderField. Current findings Tests that seem to be caused by bugs - testConvertWindowToSql Put in fix for egregious issue of (group by 10) in query 1. Ignore ordinals when in an aliasContext was fix. Don’t know enough about what it’s doing in the rest to be sure if they’re correct. 6 & 8 definitely seem wrong - testMySqlUnparseListAggCall listagg() order by shouldn't be ordinals, seems needlessly confusing Tests that insert a pretty crazy select clause, not sure if it’s what we want - testOrderByNotInSelectList - testRewriteOrderByWithNumericConstants - testSelectQueryWithAscDescOrderByClause - testSelectQueryWithLimitOffsetClause - testSelectQueryWithTwoOrderByClause -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
