zabetak commented on PR #3145: URL: https://github.com/apache/calcite/pull/3145#issuecomment-1612614757
@mihaibudiu Thanks for pushing this forward. Indeed I think we are pretty close. One basic point that we need to agree on before I do full review of the new part is the duration & frequency of running the new tests. I see that the new tests are tagged as `Slow`. Currently we run `Slow` tests on every commit that lands in master and without the changes under this PR they take ~30minutes. How much time do the new test take at the moment and how often do we want to run them? We should take into account that things are usually much faster locally than in CI. As I mentioned earlier (https://github.com/apache/calcite/pull/3145#issuecomment-1580300860) we don't need to address everything as part of this PR. However, I would like to have some of the tests enabled and running as part of the unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
