mihaibudiu commented on code in PR #3286:
URL: https://github.com/apache/calcite/pull/3286#discussion_r1246899802
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -7347,6 +7347,8 @@ private static void
checkSubstringFunction(SqlOperatorFixture f) {
"ab", "VARCHAR(3) NOT NULL");
f.checkString("substring(x'aabbcc' from 1 for 2)",
"aabb", "VARBINARY(3) NOT NULL");
+ f.checkString("substring('abc' from 2 for 2147483646)",
Review Comment:
This is a trick question, it may depend on the SQL dialect.
This implementation supports any `int` values for these arguments.
So you are suggesting adding negative tests that fail if the values are out
of the `int` range?
I will look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
