herunkang2018 commented on code in PR #3211:
URL: https://github.com/apache/calcite/pull/3211#discussion_r1251376779
##########
core/src/test/resources/sql/functions.iq:
##########
@@ -938,5 +938,20 @@ table(AUX.TBLFUN_IDENTITY(3)) as t3(v);
!ok
+# SUBSTRING
+-- returns 'null'
+select SUBSTRING(NULL FROM 1 FOR 2);
+select SUBSTRING('text' FROM 1 FOR NULL);
+select SUBSTRING('text' FROM NULL FOR 2);
+select SUBSTRING(s from i for l) from (values ('abc', null, 2)) as t (s, i, l);
Review Comment:
minor comment, better to unify the usage of uppercase and lowercase. You
could follow the test cases above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
