JiajunBernoulli commented on code in PR #3291:
URL: https://github.com/apache/calcite/pull/3291#discussion_r1252459082
##########
babel/src/test/java/org/apache/calcite/test/BabelTest.java:
##########
@@ -130,6 +131,17 @@ private void checkInfixCast(Statement statement, String
typeName, int sqlType)
/** Tests that you can run tests via {@link Fixtures}. */
@Test void testFixtures() {
final SqlValidatorFixture v = Fixtures.forValidator();
+
+ v.withParserConfig(c -> c.withParserFactory(SqlBabelParserImpl.FACTORY))
Review Comment:
Agree with NobiGo.
Add Java Document also will be better, for example:
```
/** Test case for
* <a
href="https://issues.apache.org/jira/browse/CALCITE-5816";>[CALCITE-5816]
* Query with LEFT SEMI JOIN should not refer to RHS columns</a>. */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
