tanclary commented on PR #3234: URL: https://github.com/apache/calcite/pull/3234#issuecomment-1622537648
@zoudan @julianhyde I have pushed a new commit that addresses several things. I have also updated the JIRA case to detail some of the decisions this PR includes. There are 9 combinations in `SqlFunctions`, from pairings of `Long`, `BigDecimal` and `Double`. I also added checks for `Infinity` and adjusted the way I calculated overflow for `BigDecimal` and `Double` types. The testing is also more thorough now, which each combination being tested for both normal and overflow behavior. If either of you have time to take another look, please feel free to leave more comments. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
