julianhyde commented on PR #3147:
URL: https://github.com/apache/calcite/pull/3147#issuecomment-1624482681
Is the new function class `SqlContainsSubstrFunction` necessary?
Thanks for adding javadoc in SqlFunctions. For future reference, `{@code ...
}` is slightly preferred over `<code> ... </code>` because it handles some HTML
escaping. (Of course you can't use it if you actually want HTML markup e.g.
`<b>`and `<br>`.)
I'd rename `enum JsonScopeValue` to `enum JsonScope`. Every class holds
values.
Make `normalize` private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
