zoudan commented on code in PR #3290: URL: https://github.com/apache/calcite/pull/3290#discussion_r1255153032
########## site/_docs/reference.md: ########## @@ -2752,6 +2752,8 @@ BigQuery's type system uses confusingly different names for types and functions: | b | FROM_BASE32(string) | Returns the decoded result of a base-32 *string* as a string | m | TO_BASE64(string) | Converts the *string* to base-64 encoded form and returns a encoded string | b m | FROM_BASE64(string) | Returns the decoded result of a base-64 *string* as a string +| b | TO_HEX(binary) | Converts *binary* into a hexadecimal varchar +| b | FROM_HEX(varchar) | Converts a hexadecimal-encoded *varchar* into bytes Review Comment: @tanclary IMO, people can easily confuse `string` and `varchar`, as we described in [CALCITE-5777](https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-5777?filter=myopenissues). STRING_TYPES not only contains CHAR_TYPES, but also BINARY_TYPES. `public static final List<SqlTypeName> STRING_TYPES = combine(CHAR_TYPES, BINARY_TYPES);` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
