NobiGo commented on code in PR #3299:
URL: https://github.com/apache/calcite/pull/3299#discussion_r1257610797
##########
core/src/test/java/org/apache/calcite/rex/RexProgramBuilderBase.java:
##########
@@ -756,8 +759,8 @@ protected RexNode vParam(String name, RelDataType type) {
*/
protected RexNode vParam(String name, int arg, RelDataType type) {
assertArgValue(arg);
- RelDataType nonNullableType = typeFactory.createTypeWithNullability(type,
false);
- return rexBuilder.makeFieldAccess(getDynamicParam(nonNullableType, name),
arg);
+ RelDataType nullableType = typeFactory.createTypeWithNullability(type,
true);
Review Comment:
This line code is necessary? Because we have changed the code logic, The
Test still passes, So this is an invalid code？
##########
core/src/test/java/org/apache/calcite/rex/RexProgramBuilderBase.java:
##########
@@ -756,8 +759,8 @@ protected RexNode vParam(String name, RelDataType type) {
*/
protected RexNode vParam(String name, int arg, RelDataType type) {
assertArgValue(arg);
- RelDataType nonNullableType = typeFactory.createTypeWithNullability(type,
false);
- return rexBuilder.makeFieldAccess(getDynamicParam(nonNullableType, name),
arg);
+ RelDataType nullableType = typeFactory.createTypeWithNullability(type,
true);
Review Comment:
This line code is necessary? Because we have changed the code logic, The
Test still passes, So this is an invalid code？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
