zabetak commented on PR #3259: URL: https://github.com/apache/calcite/pull/3259#issuecomment-1630595750
@JiajunBernoulli @liuyongvs Changing the way that production code behaves cannot be considered a minor contribution. This change shouldn't have gone through without a JIRA ticket. Ideally, there should be also test cases validating that we are correctly bailing out according to the new code that was added. The minor prefix is also misleading for the release manager as well as users reading the release notes. Please keep this in mind for future changes. See also relevant thread about minor/small contributions: https://lists.apache.org/thread/pljc1vhg6bl400qpjts3obmm9zvo9pt1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
