chucheng92 commented on code in PR #3313:
URL: https://github.com/apache/calcite/pull/3313#discussion_r1261981582
##########
plus/src/main/java/org/apache/calcite/chinook/ChinookAvaticaServer.java:
##########
@@ -62,16 +62,18 @@ public static class CalciteChinookMetaFactory implements
Meta.Factory {
private static final CalciteConnectionProvider CONNECTION_PROVIDER =
new CalciteConnectionProvider();
- private static JdbcMeta instance = null;
+ private static volatile JdbcMeta instance = null;
private static JdbcMeta getInstance() {
if (instance == null) {
- try {
- instance =
- new JdbcMeta(CalciteConnectionProvider.DRIVER_URL,
- CONNECTION_PROVIDER.provideConnectionInfo());
- } catch (SQLException | IOException e) {
- throw new RuntimeException(e);
+ synchronized (JdbcMeta.class) {
Review Comment:
@chucheng92 hi, benchao. thanks for reviewing. updated.
##########
plus/src/main/java/org/apache/calcite/chinook/ChinookAvaticaServer.java:
##########
@@ -62,16 +62,18 @@ public static class CalciteChinookMetaFactory implements
Meta.Factory {
private static final CalciteConnectionProvider CONNECTION_PROVIDER =
new CalciteConnectionProvider();
- private static JdbcMeta instance = null;
+ private static volatile JdbcMeta instance = null;
private static JdbcMeta getInstance() {
if (instance == null) {
- try {
- instance =
- new JdbcMeta(CalciteConnectionProvider.DRIVER_URL,
- CONNECTION_PROVIDER.provideConnectionInfo());
- } catch (SQLException | IOException e) {
- throw new RuntimeException(e);
+ synchronized (JdbcMeta.class) {
Review Comment:
@libenchao hi, benchao. thanks for reviewing. updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
