libenchao commented on code in PR #3316:
URL: https://github.com/apache/calcite/pull/3316#discussion_r1263219460
##########
core/src/main/java/org/apache/calcite/rex/RexUtil.java:
##########
@@ -2670,7 +2671,8 @@ private List<RexNode> pullList(List<RexNode> nodes) {
}
private static Map<RexNode, RexNode> commonFactors(List<RexNode> nodes) {
- final Map<RexNode, RexNode> map = new HashMap<>();
+ // make commonFactors method result be deterministic order.
Review Comment:
```suggestion
// make sure the result is in deterministic order
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
