tanclary commented on code in PR #3327:
URL: https://github.com/apache/calcite/pull/3327#discussion_r1268776940
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java:
##########
@@ -2701,11 +2701,10 @@ public static SqlOperator like(boolean negated, boolean
caseSensitive) {
/** Returns the operator for {@code FLOOR} and {@code CEIL} with given floor
flag
* and library. */
- public static SqlOperator floorCeil(boolean floor, SqlConformanceEnum
conformance) {
- switch (conformance) {
- case BIG_QUERY:
+ public static SqlOperator floorCeil(boolean floor, SqlConformance
conformance) {
+ if (SqlConformanceEnum.BIG_QUERY.equals(conformance)) {
Review Comment:
Is there a test you can add for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
