LakeShen commented on code in PR #3337:
URL: https://github.com/apache/calcite/pull/3337#discussion_r1277170260
##########
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##########
@@ -906,6 +906,29 @@ protected static SortedSet<String> keywords(@Nullable
String dialect) {
.ok(expectedBigQuery);
}
+ @Test void testDecimalLiteral() {
Review Comment:
> I would remove the blank lines within this method. The test cases are so
uniform that extra vertical space is not needed.
>
> You should also test values that start and end with '.', values with no
'.', values in scientific notation, the empty string, just '-', and invalid
strings such as 'foo'.
>
> In BigQuery conformance you should allow values with double-quotes, e.g.
`DECIMAL "-12.3"`.
Hi @julianhyde ,I have modified the code according to your Review
suggestion. If you have any ideas, please let me know. Thank you very much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
