asolimando commented on code in PR #3316:
URL: https://github.com/apache/calcite/pull/3316#discussion_r1279077281
##########
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##########
@@ -801,6 +804,17 @@ private void checkExponentialCnf(int n) {
and(eRef,
or(fRef,
and(gRef, or(trueLiteral, falseLiteral)))))))));
+
Review Comment:
Mmm, I think I have to execute the test until it fails (the order is
non-deterministic without your fix), sometimes it can be OK but it's not
guaranteed.
I don't see a way we can improve this test further (e.g., making it fail
with `HashMap` consistently), because of the nature of the change, but I think
it's already something that the test will become flaky if in the future we
break the determinism you just introduced thanks to the `LinkedHashMap`.
In summary, I am OK with the test, I don't see how it can be (easily)
improved further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
