rubenada commented on PR #3344: URL: https://github.com/apache/calcite/pull/3344#issuecomment-1658072016
Thanks for the patch, @mihaibudiu. The fix LGTM. I assume the same error would happen with `select split(NULL)`, if that is the case, could you please add that test too in `RelOptRulesTest.java`? Also, could you please adjust the JIRA title (and hence the PR title, commit message, and new unit tests javadoc) to describe a bit more clearly the issue, I'd suggest something along the lines: `[CALCITE-5879] AssertionError during constant reduction of SPLIT expression that returns NULL` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
