rubenada commented on PR #3341:
URL: https://github.com/apache/calcite/pull/3341#issuecomment-1659713963
Thanks @mihaibudiu , just one final, minor detail: the comment of the new
unit test has the form of comment lines, could you please change it into
javadoc with a proper link? (just to keep consistency with other similar
comments in the same test class).
I can see that the comment of the next test is also using comment lines
instead of javadoc (probably this is where the confusion comes from), but this
seems an anomaly, and should also be changed to keep consistency within the
class, so I'd suggest to take advantage of this PR and fix that comment too:
```
/** Test case for
* <a
href="https://issues.apache.org/jira/browse/CALCITE-5877";>[CALCITE-5877]
* AssertionError during MOD operation if result scale is greater than
maximum numeric scale</a>. */
@Test void testNumericScaleMod() {
final String sql = "SELECT MOD(CAST(2 AS DECIMAL(39, 20)), 2)";
final String expected = "SELECT MOD(2, 2)\nFROM (VALUES (0)) AS \"t\"
(\"ZERO\")";
sql(sql).withPostgresqlModifiedDecimalTypeSystem()
.ok(expected);
}
/** Test case for
* <a
href="https://issues.apache.org/jira/browse/CALCITE-5651";>[CALCITE-5651]
* Inferred scale for decimal should not exceed maximum allowed scale</a>.
*/
@Test void testNumericScale() {
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
