NobiGo commented on code in PR #3339:
URL: https://github.com/apache/calcite/pull/3339#discussion_r1280340504
##########
redis/src/test/java/org/apache/calcite/adapter/redis/RedisCaseBase.java:
##########
@@ -113,7 +113,7 @@ public static int getAvailablePort() {
@AfterAll
public static void stopRedisContainer() {
- if (REDIS_CONTAINER != null && REDIS_CONTAINER.isRunning()) {
Review Comment:
LGTM
##########
redis/src/test/java/org/apache/calcite/adapter/redis/RedisDataCaseBase.java:
##########
@@ -99,8 +99,6 @@ public void makeData() {
@AfterEach
public void shutDown() {
- if (null != pool) {
Review Comment:
I don't think so. When we init the pool throw exception, if, remove the
condition, the code will throw NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
