tanclary commented on code in PR #3338:
URL: https://github.com/apache/calcite/pull/3338#discussion_r1280829992
##########
core/src/main/resources/org/apache/calcite/runtime/CalciteResource.properties:
##########
@@ -329,6 +329,7 @@ InvalidInputForJsonKeys=Invalid input for JSON_KEYS: ''{0}''
InvalidInputForJsonRemove=Invalid input for JSON_REMOVE: document: ''{0}'',
jsonpath expressions: ''{1}''
InvalidInputForJsonStorageSize=Invalid input for JSON_STORAGE_SIZE: ''{0}''
InvalidInputForRegexpReplace=Invalid input for REGEXP_REPLACE: ''{0}''
+InvalidInputForRegexpContains=Invalid regex input for REGEXP_CONTAINS: ''{0}''
Review Comment:
Sorry for the nit but maybe contains should go above replace to preserve
alphabetic order for the group, it seems like the other sets of functions
follow it which is why I suggest it.
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -467,6 +467,14 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding
operatorBinding,
@LibraryOperator(libraries = {MYSQL, ORACLE})
public static final SqlFunction REGEXP_REPLACE = new
SqlRegexpReplaceFunction();
+ /** The "REGEXP_CONTAINS(value, regexp)" function.
+ * Returns TRUE if value is a partial match for the regular expression,
regexp. */
+ @LibraryOperator(libraries = {BIG_QUERY})
+ public static final SqlFunction REGEXP_CONTAINS =
+ SqlBasicFunction.create("REGEXP_CONTAINS",
ReturnTypes.BOOLEAN_NULLABLE,
+ OperandTypes.STRING_STRING,
Review Comment:
Is the indentation off here? Look at below functions for other examples
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
