herunkang2018 commented on code in PR #3319:
URL: https://github.com/apache/calcite/pull/3319#discussion_r1290149728


##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -815,6 +815,39 @@ public static int bitLength(ByteString s) {
     return s.length() * 8;
   }
 
+  /** SQL BIT_GET(value, position) function. */
+  public static int bitGet(long value, int position) {

Review Comment:
   According to Spark's [PR](https://github.com/apache/spark/pull/31198/files) 
to implement BIT_GET function, currently we don't support decimal type. For 
consistency, I think we should not take other number types like Decimal into 
consideration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to