LakeShen commented on code in PR #3360:
URL: https://github.com/apache/calcite/pull/3360#discussion_r1290829464
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -1104,6 +1104,16 @@ private SqlNode validateScopedExpression(
List<SqlNode> operands = ((SqlCall) node).getOperandList();
SqlSampleSpec sampleSpec = SqlLiteral.sampleValue(operands.get(1));
if (sampleSpec instanceof SqlSampleSpec.SqlTableSampleSpec) {
+ // The sampling percentage is between 0(0%) and 1(100%),1 is exclusive
+ float samplePercentage =
Review Comment:
Hi @julianhyde ,I had the same idea with you to change samplePercentag to
Bigdecimal. I thought that there was some reason to set samplePercentag to
float before, so I did not change this code.
I will follow your advice today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
