Anthrino commented on PR #3338: URL: https://github.com/apache/calcite/pull/3338#issuecomment-1677898074
> I've made a few cosmetic suggestions. Hopefully they are easy to fix. > Thanks for the review @julianhyde, I've made the changes. Unfortunately I ran into some conflicts while rebasing this branch which led to duplicate changes from other merged PRs. Had to force push some changes to the remote branch when resolving the conflicts, hence your comments are tagged to outdated files but the changes are added to the latest versions. Sorry for the confusion, please review and let me know. > Also, you need to add to `SqlOperatorTest`. There are currently no tests for scenarios where REGEXP_CONTAINS returns null (null first or second argument). I had added three checkNull tests to test these null arg scenarios in Operator tests, am I missing any other means of testing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
