macroguo-ghy commented on code in PR #3373:
URL: https://github.com/apache/calcite/pull/3373#discussion_r1297936989
##########
site/_docs/reference.md:
##########
@@ -2681,6 +2681,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| b | CEIL(value) | Similar to standard
`CEIL(value)` except if *value* is an integer type, the return type is a double
| m s | CHAR(integer) | Returns the character
whose ASCII code is *integer* % 256, or null if *integer* < 0
| b o p | CHR(integer) | Returns the character
whose UTF-8 code is *integer*
+| b | CODE_POINTS_TO_BYTES(array<integer>) | Converts an
*array<integer>* of extended ASCII code points to bytes, return null if
array is null or the element of the array is null
Review Comment:
Thanks for your suggestion! I change the argument name and description.
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -816,6 +816,33 @@ public static String charFromUtf8(int n) {
return String.valueOf(Character.toChars(n));
}
+ /**
+ * SQL CODE_POINTS_TO_BYTES function.
+ */
+ public static @Nullable ByteString codePointsToBytes(@Nullable List
codePoints) {
+ if (codePoints == null) {
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
