tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1300608395
########## site/_docs/reference.md: ########## @@ -2783,7 +2783,9 @@ BigQuery's type system uses confusingly different names for types and functions: | h s | PARSE_URL(urlString, partToExtract [, keyToExtract] ) | Returns the specified *partToExtract* from the *urlString*. Valid values for *partToExtract* include HOST, PATH, QUERY, REF, PROTOCOL, AUTHORITY, FILE, and USERINFO. *keyToExtract* specifies which query to extract | b | POW(numeric1, numeric2) | Returns *numeric1* raised to the power *numeric2* | b | REGEXP_CONTAINS(string, regexp) | Returns whether *string* is a partial match for the *regexp* +| b | REGEXP_EXTRACT(string, regexp[, position[, occurrence]]) | Returns the substring in *string* that matches the *regexp*. Returns `NULL` if there is no match. Use *position* for the start index of search range and *occurrence* for the specific occurence of match in *string* Review Comment: Don't think NULL should be quoted based on other usages. Do you think you could rewrite to sort of match the `INSTR` description? That might be more simple and is a good example of a function with optional arguments. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
