herunkang2018 commented on code in PR #3389:
URL: https://github.com/apache/calcite/pull/3389#discussion_r1305571505
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -929,6 +929,29 @@ public static String charFromUtf8(int n) {
return String.valueOf(Character.toChars(n));
}
+ /**
+ * SQL CODE_POINTS_TO_BYTES function.
+ */
+ public static @Nullable ByteString codePointsToBytes(List codePoints) {
Review Comment:
I notice that operand type chceker is `ARRAY_OF_INTEGER`, so IMO in runtime,
it always be array of integer as operand, and not necessary to add the check
logic for long value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
