herunkang2018 commented on code in PR #225:
URL: https://github.com/apache/calcite-avatica/pull/225#discussion_r1313684206
##########
core/src/test/java/org/apache/calcite/avatica/util/TimestampFromNumberAccessorTest.java:
##########
@@ -101,6 +101,9 @@ public class TimestampFromNumberAccessorTest {
value = DateTimeUtils.timestampStringToUnixDate("2014-09-30 15:28:27.356");
assertThat(instance.getString(), is("2014-09-30 15:28:27"));
+ value = DateTimeUtils.timestampStringToUnixDate("2014-2-2 15:28:27.356");
Review Comment:
Could you add test case to cover `'1945-2-2 12:2:5'` and `'12:2:5' to test
the TIME type without leading zero?
##########
core/src/test/java/org/apache/calcite/avatica/util/TimestampFromNumberAccessorTest.java:
##########
@@ -101,6 +101,9 @@ public class TimestampFromNumberAccessorTest {
value = DateTimeUtils.timestampStringToUnixDate("2014-09-30 15:28:27.356");
assertThat(instance.getString(), is("2014-09-30 15:28:27"));
+ value = DateTimeUtils.timestampStringToUnixDate("2014-2-2 15:28:27.356");
Review Comment:
Could you add test case to cover `'1945-2-2 12:2:5'` and `'12:2:5'` to test
the TIME type without leading zero?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
