rubenada commented on code in PR #3382:
URL: https://github.com/apache/calcite/pull/3382#discussion_r1314595347
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdRowCount.java:
##########
@@ -169,6 +170,12 @@ public Double getRowCount(Calc rel, RelMetadataQuery mq) {
return limit < rowCount ? limit : rowCount;
}
+ public @Nullable Double getRowCount(Sample rel, RelMetadataQuery mq) {
+ final Double rowCount = mq.getRowCount(rel.getInput());
Review Comment:
nitpick: I'd name this variable `inputRowCount` or something like that.
Also, as Julian mentions, perhaps a comment would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
