[GitHub] [calcite] rubenada commented on a diff in pull request #3407: [CALCITE-5952] Semi-Join incorrectly reordered with Left-Join by SemiJoinJoinTransposeRule

[via GitHub]

rubenada commented on code in PR #3407:
URL: https://github.com/apache/calcite/pull/3407#discussion_r1314852797


##########
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinJoinTransposeRule.java:
##########
@@ -114,6 +114,18 @@ public SemiJoinJoinTransposeRule(RelBuilderFactory 
relBuilderFactory) {
       return;
     }
 
+    // join type need to allow pushing predicate (represented as semi-join in 
our case)

Review Comment:
   Minor: need**s**
   Also, I'd say "input" rather than "branch"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org