LakeShen commented on code in PR #3415:
URL: https://github.com/apache/calcite/pull/3415#discussion_r1320736268
##########
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java:
##########
@@ -565,6 +565,9 @@ void ensureRootConverters() {
}
}
for (RelSubset subset : root.set.subsets) {
+ if (subset == root) {
Review Comment:
I'm not sure whether the logic of these lines of code is correct, could you
add a unit test for this logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
