macroguo-ghy commented on code in PR #3416:
URL: https://github.com/apache/calcite/pull/3416#discussion_r1321367481
##########
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##########
@@ -1993,6 +1993,7 @@ private RexNode simplifyOrs(List<RexNode> terms,
RexUnknownAs unknownAs) {
// or 'X IS NOT NULL' if a simplification takes place (because another
'X<>B' is found)
final Map<RexNode, RexNode> notEqualsComparisonMap = new HashMap<>();
final RexLiteral trueLiteral = rexBuilder.makeLiteral(true);
+ boolean removeNull = false;
Review Comment:
I remove this logic because I found `simplifyOrs` method will call
`flattenOr` eventually which use a `set` to eliminate duplicates. So we don't
need to handle multiple `NULL` literal separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
