libenchao commented on code in PR #3419:
URL: https://github.com/apache/calcite/pull/3419#discussion_r1328054402
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -220,6 +220,16 @@ private static String toSql(RelNode root, SqlDialect
dialect,
.getSql();
}
+ /**
+ * Test for <a
href="https://issues.apache.org/jira/browse/CALCITE-5988">[CALCITE-5988]</a>
+ * SqlImplementor.toSql cannot emit VARBINARY literals.
+ */
+ @Test void testBinary() {
+ String query = "SELECT x'ABCD'";
+ String expected = "SELECT X'ABCD'";
+ sql(query).withMysql().ok(expected);
Review Comment:
I'm fine with leaving as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]