LakeShen commented on code in PR #3418:
URL: https://github.com/apache/calcite/pull/3418#discussion_r1329956216
##########
core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java:
##########
@@ -715,6 +715,11 @@ private CoreRules() {}
public static final SortRemoveConstantKeysRule SORT_REMOVE_CONSTANT_KEYS =
SortRemoveConstantKeysRule.Config.DEFAULT.toRule();
+ /** Rule that removes redundant {@link Sort} if its input max row number
+ * is less than or equal one. */
+ public static final RemoveRedundantSort REMOVE_REDUNDANT_SORT =
Review Comment:
Hi @rubenada ,thank you very much for your review.
My idea was to change the name to SortRemoveRedundantRule,I also plan to add
more optimization logic to this rule in the future,such as redundant
limit,redundant topn
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
