LakeShen commented on code in PR #3406:
URL: https://github.com/apache/calcite/pull/3406#discussion_r1331779835
##########
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchJson.java:
##########
@@ -98,7 +98,9 @@ static void visitMappingProperties(ObjectNode mapping,
BiConsumer<String, String> consumer) {
Objects.requireNonNull(mapping, "mapping");
Objects.requireNonNull(consumer, "consumer");
- visitMappingProperties(new ArrayDeque<>(), mapping, consumer);
+ if (mapping.has("properties")) {
Review Comment:
Why you add this check?Could you give the code comments to explain this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
