JiajunBernoulli commented on code in PR #3431:
URL: https://github.com/apache/calcite/pull/3431#discussion_r1334939074
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##########
@@ -1878,6 +1878,11 @@ && hasSortByOrdinal()) {
&& (hasNestedAgg || hasNestedWindowedAgg)) {
return true;
}
+ if (!dialect.supportsNestedAggregations()
+ && agg.getInput() instanceof Project
Review Comment:
When will the input of Aggreagte be Window?
Window only appear when you use `ProjectToWindowRule` and I think the window
will not be input of Aggregate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
