julianhyde commented on code in PR #3421:
URL: https://github.com/apache/calcite/pull/3421#discussion_r1337841370
##########
core/src/main/java/org/apache/calcite/jdbc/CalciteMetaImpl.java:
##########
@@ -90,13 +90,40 @@
public class CalciteMetaImpl extends MetaImpl {
static final Driver DRIVER = new Driver();
+ private final CalciteMetaTableFactory metaTableFactory;
+ private final CalciteMetaColumnFactory metaColumnFactory;
+
+ /** Creates a CalciteMetaImpl.
+ *
+ * @deprecated Use
+ * {@link #CalciteMetaImpl(CalciteConnectionImpl, CalciteMetaTableFactory,
CalciteMetaColumnFactory)}
+ * instead.
+ */
+ @Deprecated // to be removed before 2.0
public CalciteMetaImpl(CalciteConnectionImpl connection) {
+ this(connection, new CalciteMetaTableFactoryImpl(), new
CalciteMetaColumnFactoryImpl());
+ }
+
+ public CalciteMetaImpl(CalciteConnectionImpl connection,
Review Comment:
I think CI is finding cases where you might accidentally supply null (e.g.
when `Driver` calls `config.metaColumnFactory`). I'll fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
