chucheng92 commented on code in PR #3458:
URL: https://github.com/apache/calcite/pull/3458#discussion_r1349538846
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -532,26 +532,30 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding
operatorBinding,
public static final SqlFunction EXTRACT_VALUE =
SqlBasicFunction.create("EXTRACTVALUE",
ReturnTypes.VARCHAR_2000.andThen(SqlTypeTransforms.FORCE_NULLABLE),
- OperandTypes.STRING_STRING);
+ OperandTypes.STRING_STRING,
Review Comment:
@LakeShen I get your point. Usually we classify functions according to the
operands (in some cases, they can also be determined according to the return
value type).
more details pls see: ANSI sql function category:
https://www.oreilly.com/library/view/sql-in-a/9780596155322/ch04s04.html.
The string function category can return string & numeric values. Generally
speaking, these functions(in this PR) process XML text and conform to the
definition of String category rather than Numeric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
