zhougit86 commented on code in PR #3474:
URL: https://github.com/apache/calcite/pull/3474#discussion_r1363200139
##########
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##########
@@ -1792,13 +1792,12 @@ void checkPeriodPredicate(Checker checker) {
expr("cast('foo' as bar)")
.ok("CAST('foo' AS `BAR`)");
}
-
+
@Test void testParsingNonIsoCharacter() {
String sql = "select 'ק' ";
- sql(sql).ok("SELECT u&'\\05e7'");
Review Comment:
the CALCITE-6001 mentioned
'This means that when converting a query like:
select 'ק' as result;
you will get the following the error: Failed to encode 'ק' in character set
'ISO-8859-1'.'
I justed it according to this behavior
##########
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##########
@@ -1792,13 +1792,12 @@ void checkPeriodPredicate(Checker checker) {
expr("cast('foo' as bar)")
.ok("CAST('foo' AS `BAR`)");
}
-
+
@Test void testParsingNonIsoCharacter() {
String sql = "select 'ק' ";
- sql(sql).ok("SELECT u&'\\05e7'");
Review Comment:
the CALCITE-6001 mentioned
'This means that when converting a query like:
select 'ק' as result;
you will get the following the error: Failed to encode 'ק' in character set
'ISO-8859-1'.'
I justed it according to this behavior
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -1486,6 +1486,9 @@ private static String toSql(RelNode root, SqlDialect
dialect,
assertThat(toSql(root), isLinux(expectedSql));
}
+
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
