mihaibudiu commented on code in PR #3479: URL: https://github.com/apache/calcite/pull/3479#discussion_r1367939489
########## site/_docs/reference.md: ########## @@ -2739,6 +2739,9 @@ BigQuery's type system uses confusingly different names for types and functions: | b | FORMAT_TIMESTAMP(string timestamp) | Formats *timestamp* according to the specified format *string* | s | GETBIT(value, position) | Equivalent to `BIT_GET(value, position)` | b o | GREATEST(expr [, expr ]*) | Returns the greatest of the expressions +| h s | HEX(binary) | Converts *binary* into a hexadecimal varchar +| h s | HEX(bigint) | Converts *bigint* into a shortened hexadecimal varchar +| h s | HEX(varchar) | Converts *varchar* into a hexadecimal varchar Review Comment: This description does not explain what is really going on. Can you give an example? ########## site/_docs/reference.md: ########## @@ -2739,6 +2739,9 @@ BigQuery's type system uses confusingly different names for types and functions: | b | FORMAT_TIMESTAMP(string timestamp) | Formats *timestamp* according to the specified format *string* | s | GETBIT(value, position) | Equivalent to `BIT_GET(value, position)` | b o | GREATEST(expr [, expr ]*) | Returns the greatest of the expressions +| h s | HEX(binary) | Converts *binary* into a hexadecimal varchar +| h s | HEX(bigint) | Converts *bigint* into a shortened hexadecimal varchar +| h s | HEX(varchar) | Converts *varchar* into a hexadecimal varchar Review Comment: Also, you should explain what happens if the string is not well-formed ########## site/_docs/reference.md: ########## @@ -2852,6 +2855,7 @@ BigQuery's type system uses confusingly different names for types and functions: | b o p | TRANSLATE(expr, fromString, toString) | Returns *expr* with all occurrences of each character in *fromString* replaced by its corresponding character in *toString*. Characters in *expr* that are not in *fromString* are not replaced | b | TRUNC(numeric1 [, numeric2 ]) | Truncates *numeric1* to optionally *numeric2* (if not specified 0) places right to the decimal point | q | TRY_CAST(value AS type) | Converts *value* to *type*, returning NULL if conversion fails +| h s | UNHEX(varchar) | Converts a hexadecimal-encoded *varchar* into bytes Review Comment: what happens if this fail? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
