mihaibudiu commented on code in PR #3318: URL: https://github.com/apache/calcite/pull/3318#discussion_r1370812570
########## site/_docs/reference.md: ########## @@ -2854,6 +2854,8 @@ BigQuery's type system uses confusingly different names for types and functions: | b | UNIX_MILLIS(timestamp) | Returns the number of milliseconds since 1970-01-01 00:00:00 | b | UNIX_SECONDS(timestamp) | Returns the number of seconds since 1970-01-01 00:00:00 | b | UNIX_DATE(date) | Returns the number of days since 1970-01-01 +| s | URL_DECODE(string) | Decodes a *string* in 'application/x-www-form-urlencoded' format using a specific encoding scheme Review Comment: You should specify what happens if the function fails to encode/decode. Is the result NULL or a runtime error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
