rubenada commented on PR #3480: URL: https://github.com/apache/calcite/pull/3480#issuecomment-1778712954
Nice work @HanumathRao ! I have left some (minor) comments. I'm not the biggest expert on the parser and validator, so I'd prefer if someone else would take a look at that part. Thanks for adding such a thorough amount of tests. I think there is one part of the documentation that needs to be updated in the PR: in `algebra.md`, in the "Recursive Queries", this paragraph should be removed :) ``` Note that there is no support for recursive queries in the SQL layer yet ([CALCITE-129](https://issues.apache.org/jira/browse/CALCITE-129)); the `WITH RECURSIVE` query above is only for illustrative purposes. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
