julianhyde commented on code in PR #3472: URL: https://github.com/apache/calcite/pull/3472#discussion_r1372200064
########## site/_docs/reference.md: ########## @@ -2693,7 +2693,7 @@ BigQuery's type system uses confusingly different names for types and functions: | m p | CONCAT_WS(separator, str1 [, string ]*) | Concatenates one or more strings, returns null only when separator is null, otherwise treats null arguments as empty strings | q | CONCAT_WS(separator, str1, str2 [, string ]*) | Concatenates two or more strings, requires at least 3 arguments (up to 254), treats null arguments as empty strings | m | COMPRESS(string) | Compresses a string using zlib compression and returns the result as a binary string -| b | CONTAINS_SUBSTR(expression, string [ , json_scope=>json_scope_value ]) | Returns whether *string* exists as a substring in *expression*. Optional *json_scope* argument specifies what scope to search if *expression* is in JSON format. Returns NULL if a NULL exists in *expression* that does not result in a match +| b | CONTAINS_SUBSTR(expression, string [ , json_scope => json_scope_value ]) | Returns true when *string* exists as a substring in *expression*. Optional *json_scope* argument specifies what scope to search if *expression* is in JSON format. Returns NULL if a NULL exists in *expression* that does not result in a match Review Comment: I prefer the 'whether' formulation. The 'Returns true' formulation leaves the reader to infer under what conditions the function returns false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
