rubenada commented on code in PR #3482:
URL: https://github.com/apache/calcite/pull/3482#discussion_r1372199162
##########
core/src/test/java/org/apache/calcite/test/SqlOperatorUnparseTest.java:
##########
@@ -99,6 +99,11 @@ String rewrite(String sql) throws SqlParseException {
}
}
+ @Override @Disabled("Runtime error message differs after parsing and
unparsing")
Review Comment:
@mihaibudiu ooops, my bad, this looks like a copy-paste error (which does
not have any impact due to the test being disabled), I meant to write:
```
@Override @Disabled("Runtime error message differs after parsing and
unparsing")
void testBitAndFuncRuntimeFails() {
super.testBitAndFuncRuntimeFails();
}
```
Feel free to correct this in the PR of
[CALCITE-5990](https://issues.apache.org/jira/browse/CALCITE-5990).
The reason I disabled it was that the runtime error message contains the SQL
query, and it seems that after the parse+unparse, the SQL query was not exactly
the same as the original one (e.g. newlines were added), so the actual error
was not matching the expected one.
I was a bit on a hurry to re-stabilize master, and I did not have much time
to dig into it. If you find a way to re-enable the test (within CALCITE-5990),
please go ahead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
