libenchao commented on code in PR #3483:
URL: https://github.com/apache/calcite/pull/3483#discussion_r1374639698
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java:
##########
@@ -1364,6 +1368,7 @@ public class SqlStdOperatorTable extends
ReflectiveSqlOperatorTable {
/**
* The <code>UNNEST WITH ORDINALITY</code> operator.
*/
+ @LibraryOperator(libraries = {}) // do not include in index
Review Comment:
Why do we need to remove it from the standard operators, is it a breaking
change?
##########
core/src/main/java/org/apache/calcite/sql/fun/OracleSqlOperatorTable.java:
##########
@@ -65,15 +69,6 @@ public class OracleSqlOperatorTable extends
ReflectiveSqlOperatorTable {
* Returns the Oracle operator table, creating it if necessary.
*/
public static synchronized OracleSqlOperatorTable instance() {
Review Comment:
`synchronized` is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
