JiajunBernoulli commented on code in PR #3317:
URL: https://github.com/apache/calcite/pull/3317#discussion_r1375181031
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -1076,6 +1076,32 @@ public static int levenshtein(String string1, String
string2) {
return LEVENSHTEIN_DISTANCE.apply(string1, string2);
}
+ /** SQL FIND_IN_SET(string, stringArray) function. */
+ public static int findInSet(String matchStr, String textStr) {
Review Comment:
Agree with @LakeShen.
Check null for public method always valuable.
And your unit test need have null parameter case. @herunkang2018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
