julianhyde commented on code in PR #3479:
URL: https://github.com/apache/calcite/pull/3479#discussion_r1375658575


##########
site/_docs/reference.md:
##########
@@ -2852,6 +2855,7 @@ BigQuery's type system uses confusingly different names 
for types and functions:
 | b o p | TRANSLATE(expr, fromString, toString)      | Returns *expr* with all 
occurrences of each character in *fromString* replaced by its corresponding 
character in *toString*. Characters in *expr* that are not in *fromString* are 
not replaced
 | b | TRUNC(numeric1 [, numeric2 ])                  | Truncates *numeric1* to 
optionally *numeric2* (if not specified 0) places right to the decimal point
 | q | TRY_CAST(value AS type)                        | Converts *value* to 
*type*, returning NULL if conversion fails
+| h s | UNHEX(varchar)                               | Converts a 
hexadecimal-encoded *varchar* into bytes

Review Comment:
   Can you make doc more consistent with other functions; they don't have 
parameters called `*varchar*`
   
   Doc should explicitly say what happens on failure



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to