herunkang2018 commented on code in PR #3479:
URL: https://github.com/apache/calcite/pull/3479#discussion_r1376089470
##########
site/_docs/reference.md:
##########
@@ -2739,6 +2739,9 @@ BigQuery's type system uses confusingly different names
for types and functions:
| b | FORMAT_TIMESTAMP(string timestamp) | Formats *timestamp*
according to the specified format *string*
| s | GETBIT(value, position) | Equivalent to
`BIT_GET(value, position)`
| b o | GREATEST(expr [, expr ]*) | Returns the greatest of
the expressions
+| h s | HEX(binary) | Converts *binary* into
a hexadecimal varchar. For example, hex(x'6162') returns '6162'
+| h s | HEX(bigint) | Converts *bigint* into
a shortened hexadecimal varchar. For example, hex('17') returns '11'
Review Comment:
It would be better to change example to `hex(10) returns 'A'`.
##########
site/_docs/reference.md:
##########
@@ -2739,6 +2739,9 @@ BigQuery's type system uses confusingly different names
for types and functions:
| b | FORMAT_TIMESTAMP(string timestamp) | Formats *timestamp*
according to the specified format *string*
| s | GETBIT(value, position) | Equivalent to
`BIT_GET(value, position)`
| b o | GREATEST(expr [, expr ]*) | Returns the greatest of
the expressions
+| h s | HEX(binary) | Converts *binary* into
a hexadecimal varchar. For example, hex(x'6162') returns '6162'
+| h s | HEX(bigint) | Converts *bigint* into
a shortened hexadecimal varchar. For example, hex('17') returns '11'
Review Comment:
Updated.
##########
site/_docs/reference.md:
##########
@@ -2768,7 +2771,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| m | TO_BASE64(string) | Converts the *string*
to base-64 encoded form and returns a encoded string
| b m | FROM_BASE64(string) | Returns the decoded
result of a base-64 *string* as a string
| b | TO_HEX(binary) | Converts *binary* into
a hexadecimal varchar
-| b | FROM_HEX(varchar) | Converts a
hexadecimal-encoded *varchar* into bytes
+| b | FROM_HEX(varchar) | Converts a
hexadecimal-encoded *varchar* into bytes, throws exception if input is invalid
hexadecimal-encoded *varchar*
Review Comment:
Resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
