mihaibudiu commented on code in PR #3518:
URL: https://github.com/apache/calcite/pull/3518#discussion_r1390456492
##########
linq4j/src/test/java/org/apache/calcite/linq4j/test/InlinerTest.java:
##########
@@ -152,6 +154,25 @@ void checkAssignInConditionOptimizedOut(int modifiers,
String s) {
assertThat(Expressions.toString(builder.toBlock()), is(s));
}
+ @Test void testInlineTernaryNonOptimized() {
Review Comment:
I think it's customary to add a Javadoc comment indicating the issue which
is being solved. Please follow the format of the many examples existing, the
tools are very particular about the format, including the final period.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
