zabetak commented on code in PR #3517: URL: https://github.com/apache/calcite/pull/3517#discussion_r1390773736
########## site/_docs/howto.md: ########## @@ -806,7 +806,7 @@ git clean -xn ./gradlew prepareVote -Prc=0 # Push release candidate to ASF servers -./gradlew prepareVote -Prc=0 -Pasf -Pasf.git.pushRepositoryProvider=GITBOX Review Comment: The `asf.git.pushRepositoryProvider` should be inline with `asfGitSourceUsername` and `asfGitSourcePassword`. If you are using `GITBOX` then you should use the ASF credentials; if you use `GITHUB` you should use the GitHub credentials. I assume both providers should work fine if the correct credentials are set. I think there were some misconception that GITHUB was not working in the past (https://issues.apache.org/jira/browse/CALCITE-4856) but I suspect that the underlying reason was the same (mixing ASF vs. GitHub credentials). If we want to improve something it makes sense to clarify somewhere this story about the different credentials and not just change again the default values. ########## site/_docs/howto.md: ########## @@ -927,12 +927,6 @@ thread to discuss. Julian {% endhighlight %} -Use the [Apache URL shortener](https://s.apache.org) to generate -shortened URLs for the vote proposal and result emails. Examples: -[s.apache.org/calcite-1.2-vote](https://s.apache.org/calcite-1.2-vote) and -[s.apache.org/calcite-1.2-result](https://s.apache.org/calcite-1.2-result). Review Comment: My understanding is that these steps are for creating mnemonic URLs that people can easily find and refer to it in future. I don't think was ever meant to be used for the voting process it self but for later reference to it if needed. I don't have a strong opinion on keeping or removing them but they do serve a purpose. For instance, typing the following just works and brings me what I need: * https://s.apache.org/calcite-1.34.0-vote * https://s.apache.org/calcite-1.34.0-result -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
